SROA: Ensure that unused structs are preserved in ccall #43408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
the
compiler:optimizer
|
This resolves #43402 for me. |
aviatesk
reviewed
Dec 13, 2021
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
aviatesk
approved these changes
Dec 13, 2021
vtjnash
approved these changes
Dec 13, 2021
mkitti
added a commit
to JaneliaSciComp/HDF5.jl
that referenced
this pull request
Dec 14, 2021
mkitti
added a commit
to JaneliaSciComp/HDF5.jl
that referenced
this pull request
Dec 15, 2021
DilumAluthge
removed
the
merge me
musm
added a commit
to JuliaIO/HDF5.jl
that referenced
this pull request
Dec 17, 2021
* Add bzip2, lz4, and zstd filters from HDF5Plugins.jl * Create Filters interface def, add tests * Filters return 0 rather than rethrowing error * Move blosc.jl to H5Zblosc.jl * Optimize method inference, init, precompile * Register filters as when dep packages are loaded * Fix tests for lazy loaded filters * Move plugin licenses to licenses folder * Add HHMI copyright to LICENSE.txt * Remove generic register_filter method * Apply suggestions from code review for license notices Co-authored-by: Mustafa M <mus-m@outlook.com> * Implement generic register_filter on filter type * Update test/filter.jl Co-authored-by: Mustafa M <mus-m@outlook.com> * Define filters API on the type alone * H5Zblosc, H5Zbzip2, H5Zlz4, H5Zzstd as subdir pkgs * Fix typos in H5Zlz4.jl * Use PackageSpec to make dev_embedded_filters Julia 1.3 compatible * Add Licenses to subpackages * H5Zbzip2: Add 32-bit Windows support * Reorganized licenses, create root THIRDPARTY.md * Debug tests for Julia 1.8 * Revert GC.@preserve due to JuliaLang/julia#43408 * Remove debug for not deleted file in test/external.jl * Start H5Z* pkgs at 0.1.0 * Update Project.toml Co-authored-by: Mustafa M <mus-m@outlook.com> * Update Project.toml * Add filters as test targets * Update Project.toml * Cosmetic changes and instantiate filters packages directly in test file * Update docs remove external exports Co-authored-by: Mustafa M <mus-m@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #43402